Spec #136: Finished belongs to the Series — owner-owned poll gate, Lifecycle bucket dropped #163

2026-08-22T17:30:30+07:00

sulthan commented

2026-08-22 17:30:30 +07:00

Closes #136.

Spec #136 end to end: finished becomes a fact about the Series, written only by the owner, and the reader-facing Lifecycle bucket is gone.

What landed

#157 — series.finished_at bigint NOT NULL DEFAULT 0 plus the migration whose statement order is load-bearing (seed from the buckets, then flip them); both Lane queries lose the HAVING COUNT(*) FILTER (WHERE b.status <> 'finished') clause and gate on finished_at = 0 instead, with the due-query/eligible-count force asymmetry kept deliberate and commented; StatusFinished, its API special-case 400, the web tab and the templates' Finished bucket deleted.
#158 — owner Finish control on the Series detail page: confirm-gated finish, instant un-finish, admin accent (never ember, nothing is destroyed), Store.SetSeriesFinished, the two routes behind the owner gate, and the state displayed on the list row without offering the control there.
#160 — reader side: derived finished bool on the flat Bookmark (s.finished_at > 0), rendered as a text-only label in both userscripts and on the web card; read-only inbound by omission from Upsert's explicit series column list, same mechanism that already protects cover.
#161 — glossary and the stale Reader-count divergence note catch up.
#159 — finished joins the admin filter vocabulary (predicate finished_at > 0, label Finished, own aggregate count, figure last in the stats block as informational); the four clock-driven hygiene predicates (stale, never-checked, no-cover, no-chapter) exclude finished Series while unpollable, orphan and sighting-raised deliberately do not.

Verification

go vet ./... and go test ./... green on the merged branch (Docker-backed, throwaway postgres:17-alpine per package). Each ticket also passed a two-axis review (spec + standards) on its own branch before merge.

Closes #136. Spec #136 end to end: `finished` becomes a fact about the Series, written only by the owner, and the reader-facing Lifecycle bucket is gone. ## What landed - **#157** — `series.finished_at bigint NOT NULL DEFAULT 0` plus the migration whose statement order is load-bearing (seed from the buckets, then flip them); both Lane queries lose the `HAVING COUNT(*) FILTER (WHERE b.status <> 'finished')` clause and gate on `finished_at = 0` instead, with the due-query/eligible-count force asymmetry kept deliberate and commented; `StatusFinished`, its API special-case 400, the web tab and the templates' Finished bucket deleted. - **#158** — owner Finish control on the Series detail page: confirm-gated finish, instant un-finish, admin accent (never ember, nothing is destroyed), `Store.SetSeriesFinished`, the two routes behind the owner gate, and the state displayed on the list row without offering the control there. - **#160** — reader side: derived `finished` bool on the flat Bookmark (`s.finished_at > 0`), rendered as a text-only label in both userscripts and on the web card; read-only inbound by omission from `Upsert`'s explicit `series` column list, same mechanism that already protects `cover`. - **#161** — glossary and the stale Reader-count divergence note catch up. - **#159** — `finished` joins the admin filter vocabulary (predicate `finished_at > 0`, label `Finished`, own aggregate count, figure last in the stats block as informational); the four clock-driven hygiene predicates (stale, never-checked, no-cover, no-chapter) exclude finished Series while unpollable, orphan and sighting-raised deliberately do not. ## Verification `go vet ./...` and `go test ./...` green on the merged branch (Docker-backed, throwaway `postgres:17-alpine` per package). Each ticket also passed a two-axis review (spec + standards) on its own branch before merge.

sulthan added 11 commits 2026-08-22 17:30:31 +07:00

Spec #136 : finished becomes a Series fact, Lane gate rewritten on it (#157 ) 77e3f710ec

finished_at lands on series (0016 seeds it from the pre-flip finished
bookmarks, then flips those bookmarks to archived), the poll gate and
eligible count read the flag instead of a per-Reader vote, PUT rejects
the finished status like any unknown value, and the web UI drops the
Finished tab, badge and finish button. Novel merge rank is archived >
reading. Per-Reader disagreement (one Reader keeps a finished Series in
reading forever) is what the flag repairs; the cutover keeps polling
state unchanged for every Series.

Docs: glossary and stale notes catch up with the finished-Series cutover (#161 ) 6fa9972bea

Spec #136 : reader-facing finished label on the flat Bookmark (#160 ) ea7bb97112

Owner Finish control on the Series detail page: confirm-gated finish, instant un-finish (#158 ) 948ecae2cc

Restore truncated overflow-page comment dropped by the finish diff (#158 ) 410509097a

Merge #158 : Owner Finish control on the Series detail page 0be578449b

Merge #160 : Reader-facing finished label on the flat Bookmark f66b63f6de

Merge #161 : Glossary and stale Reader-count note catch-up f85641da61

Add finished Series filter; clock-driven hygiene predicates exclude it (#159 ) 0029cff27c

Fix stale comment counts found in review (#159 ) cdd2e1d72c

Merge #159 : Finished joins the admin filter vocabulary 0081a6100c

sulthan merged commit 8e4fa6448e into main

2026-08-22 17:31:53 +07:00