sulthan/mangaBookmark
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

Owner Finish control on the Series detail page: confirm-gated finish, instant un-finish #158

New Issue
Closed
opened 2026-08-22 12:37:21 +07:00 by sulthan · 1 comment
sulthan commented 2026-08-22 12:37:21 +07:00
Owner
Copy Link
Copy Source

Part of #136.

Blocked by: #157.

What to build

The owner's write path for the finished flag. A Finish control lives on the Series detail page and nowhere else: finishing takes a confirm step and stops the Lane polling that Series from the next pass; un-finishing is one press and puts it straight back in the queue. The list row still shows the state but offers no one-press way to set it.

Acceptance criteria

  • The owner can mark a Series finished from its detail page; the Lane stops polling it from the next pass.
  • Finishing is confirm-gated with an in-place confirm row reading "Mark this Series finished?" with Finish / Cancel; un-finishing fires instantly with no confirm.
  • Both directions use the admin patina accent — never danger and never ember: nothing is destroyed.
  • The detail page shows how long the Series has been finished ("since when"), using the stamp the same way the Correction stamp is used.
  • The Series list row displays the finished state but offers no control to set it.
  • The write is owner-only: no adapter, Reader, or Poll path writes the stamp; the routes sit behind the owner gate like the other admin mutations and answer with the swapped detail fragment.
  • The projection carries the stamp the way the force stamp is projected.
  • Store tests cover the finish and un-finish writes (un-finish writes zero); web tests cover the control rendering only on the detail page, the confirm gating finish, and un-finish firing instantly.
Part of #136. Blocked by: #157. ## What to build The owner's write path for the finished flag. A Finish control lives on the Series detail page and nowhere else: finishing takes a confirm step and stops the Lane polling that Series from the next pass; un-finishing is one press and puts it straight back in the queue. The list row still shows the state but offers no one-press way to set it. ## Acceptance criteria - [ ] The owner can mark a Series finished from its detail page; the Lane stops polling it from the next pass. - [ ] Finishing is confirm-gated with an in-place confirm row reading "Mark this Series finished?" with Finish / Cancel; un-finishing fires instantly with no confirm. - [ ] Both directions use the admin patina accent — never danger and never ember: nothing is destroyed. - [ ] The detail page shows how long the Series has been finished ("since when"), using the stamp the same way the Correction stamp is used. - [ ] The Series list row displays the finished state but offers no control to set it. - [ ] The write is owner-only: no adapter, Reader, or Poll path writes the stamp; the routes sit behind the owner gate like the other admin mutations and answer with the swapped detail fragment. - [ ] The projection carries the stamp the way the force stamp is projected. - [ ] Store tests cover the finish and un-finish writes (un-finish writes zero); web tests cover the control rendering only on the detail page, the confirm gating finish, and un-finish firing instantly.
sulthan added the ready-for-agent label 2026-08-22 12:37:21 +07:00
sulthan self-assigned this 2026-08-22 16:58:40 +07:00
sulthan commented 2026-08-22 17:15:09 +07:00
Author
Owner
Copy Link
Copy Source

Merged into spec-136. Owner-only Finish/Un-finish control on the Series detail page, confirm-gated finish + instant un-finish, patina accent, projection + list-row mark. Store+web tests green, cr-spec/cr-standards clean (3 Minor standards findings: 1 fixed, 2 declined as brief-mandated idiom). Commits: 948ecae, 4105090.

Merged into spec-136. Owner-only Finish/Un-finish control on the Series detail page, confirm-gated finish + instant un-finish, patina accent, projection + list-row mark. Store+web tests green, cr-spec/cr-standards clean (3 Minor standards findings: 1 fixed, 2 declined as brief-mandated idiom). Commits: 948ecae, 4105090.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or improvement
 needs-info
Waiting on reporter for more information
 needs-triage
Maintainer needs to evaluate
 ready-for-agent
Fully specified, ready for an AFK agent
 ready-for-human
Needs human implementation
 wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wontfix
Will not be actioned
No Label ready-for-agent
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sulthan
No Assignees sulthan
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sulthan/mangaBookmark#158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?