Spec #137: per-Series poll failure state, completion hint, and outbound owner notification #174

2026-08-23T11:29:45+07:00

sulthan commented

2026-08-23 11:29:45 +07:00

Implements spec #137 (spec 4 of 4 from wayfinder map #114).

Closes #137.

Tickets: #164, #165, #166, #167, #168, #169, #170, #171, #172, #173 — all closed, landed on this branch.

Summary

#164/#168: sixth outcome word not_found; per-Site completed marker predicate.
#165/#169: poll_failures row is the failure state; the pass remembers a Site-reported completion.
#166/#171: two new admin filters (failing, unverified); outbound owner notification + stall condition.
#167/#170: a failure names itself on the Series page; the completion hint reaches the owner and decides nothing.
#172: the other three fault conditions (no-browser-route, sidecar-down, adapter-broken) feeding the notifier.
#173: the landing verdict line shares the same latest.FaultsFrom judgement the notifier uses, so the page and the push cannot disagree.

cd backend && go test ./... green on the merged branch (8 packages).

Implements spec #137 (spec 4 of 4 from wayfinder map #114). Closes #137. Tickets: #164, #165, #166, #167, #168, #169, #170, #171, #172, #173 — all closed, landed on this branch. ## Summary - #164/#168: sixth outcome word `not_found`; per-Site completed marker predicate. - #165/#169: `poll_failures` row is the failure state; the pass remembers a Site-reported completion. - #166/#171: two new admin filters (`failing`, `unverified`); outbound owner notification + stall condition. - #167/#170: a failure names itself on the Series page; the completion hint reaches the owner and decides nothing. - #172: the other three fault conditions (no-browser-route, sidecar-down, adapter-broken) feeding the notifier. - #173: the landing verdict line shares the same `latest.FaultsFrom` judgement the notifier uses, so the page and the push cannot disagree. `cd backend && go test ./...` green on the merged branch (8 packages).

sulthan added 30 commits 2026-08-23 11:29:46 +07:00

Spec #164 : A sixth outcome word: not_found splits out of errors 62c2cea74e

Review: drop duplicate 404 log, scope comment wording to 4xx (Spec #164 ) f4e4055a13

Add completed markers for all six sites (#168 ) e69e513be4

site gains a Completed predicate answering whether a fetched body
carries the Site's own completed value: asura escaped props status,
demonic info-block Status pair, comix scoped detail entry (shared
comixDetailQuery helper with the cover read), kagane
publication_status only, novelfull status link, lightnovelworld
JSON-LD creativeWorkStatus. siteCompletedFrom dispatches it; an
absent hint stays false. Fixtures trimmed from live pages fetched
2026-08-22; TestSiteCompletedFrom covers completed, ongoing,
selector-removed, and challenge bodies per site, the kagane
upload/publication divergence, and an unknown site.

Note comix key-encoding fidelity in fixture comments (#168 ) f6782e212a

Record per-site probe provenance in completed fixtures (#168 ) b38dfe54e8

Spec review flagged the live-verification acceptance criterion as
unproven in the diff: the brief's adapter rule wants the probe
recorded, not just the date. Each fixture comment now names how the
live body was fetched on 2026-08-22 — curl probe for asura,
demonic and lightnovelworld; cleared Chrome tab (CDP sidecar) for
comix, kagane and novelfull, including the challenge/403 fallback
story for novelfull. Also renamed lnwCompletedRe to lnwStatusRe for
symmetry with the other site-marker vars.

Merge #164 : A sixth outcome word: not_found splits out of errors 7ef9f8c433

Merge #168 : All six Sites' completed marker, read by their adapters 4708703044

Remember when a Site called a work completed (#169 ) b517858619

Add series.site_completed_at (epoch-ms, default 0): the durable answer
#168's predicates compute. checkOne writes it after the successful read
on the zero/non-zero transition only, so a Series still completed keeps
its original stamp (the age #170 prints is 'since the Site first said
so'), one that stopped is zeroed, one that became completed is stamped.
The due query projects the column, so the transition is a field
comparison on the snapshot checkOne already holds.

Refused, unreachable and errored reads reach nothing (AC4 is placement,
not a guard); the write sits before the no-chapter and unchanged-number
returns, so a completed page whose chapter did not change still writes.
Store failure logs and carries on — the outcome word never changes.

Series-level like Latest Chapter: a bookmark's updated_at is never
touched. #170 is the surface; nothing reads the column yet.

Address review nits on #169 : stamp name, migration comment (#169 ) 86da47850c

Record poll failures as rows: the row is the failure state (#165 ) 417f809d75

Tidy blank line before RecordSeriesFailure (#165 ) caabdff15b

Merge #165 : poll_failures: the row is the failure state 4d6773692d

Merge #169 : The pass remembers when a Site called a work completed 5a32943528

# Conflicts:
#	backend/internal/latest/poller_test.go

Two new Series filters: failing, and the unverified Reader subset (#166 ) 8a56907558

Update stale Cutoff comments: the failing pair reads it too (#166 ) a560fc76d3

Owner notices: the stall, one webhook path from env to Discord (#171 ) 7b22460f5e

Rollout note: the owner_notices table starts empty, so the first pass after deploy sends for conditions already true — correct per one-row-per-episode; say so rather than have it reported as a bug. Prod step: create the webhook, set DISCORD_WEBHOOK_URL on the deployment, redeploy — unset is silent by design, and without that step the feature ships dark. Security invariants preserved: the webhook address is a secret in the class of TOKEN_KEY (never logged, never on a config-printing line), and the owner gate is unchanged.

Review fixes: compose duplicate depends_on, .env.example splice, restore COVER_DIR test (#171 ) 6af8859c70

Merge #166 : Two new filters: failing, and the subset nothing stands behind 4bb26c6225

Merge #171 : Outbound owner notification, and the stall it exists for 3d746092ab

web: site-completed hint reaches the owner, decides nothing (#170 ) a533e4f769

The Site's own completed marker (issue #168) joins the owner's surface as
an informational hint, never a decision:

- store: SeriesFilterSiteCompleted ('site_completed') sits beside Finished
  in the filter vocabulary; its predicate carries the same finished_at
  guard as the clock-driven filters, because the Site's stamp keeps
  standing after the owner retires the row. The projection and SeriesPage
  GROUP BY carry site_completed_at so the detail page can age it.
- web: the filter joins the Series list select as 'Site says completed'
  and rides the tail of seriesFilterOrder, so the landing stats figure
  comes for free and sits after the finished figure.
- detail: one hint line beside the Finish control - 'the site says this
  work is completed (since 3d ago)' - rendered only while the stamp
  stands and no Finish stands; the Finish control itself is untouched.
- tests: filter's finished exclusion and un-finish return to the Poll
  query (store); figure at zero and nonzero, hint present/absent, and the
  Finish control's markup byte-identical with a hint present (web).

web: a failure names itself on the page (issue #167 ) f85908d3b4

The Series list row's fact line gains the failure word and its age in one
mark before the Notes chips, spelled through outcomeWord — the one
vocabulary shared with the Lanes chips. The detail page adds one sentence
beside the correction control while a Reader's number stands behind a
failure past the owner window, without naming the Reader. Each Lanes Site
name is a plain link to that Site's failing Series; the outcome chips stay
unlinked, and outcomeChips records why the promise is withdrawn.

Merge #167 : A failure names itself on the page 08ffd1f93c

Merge #170 : The completion hint reaches the owner, and decides nothing 2861f055b4

# Conflicts:
#	backend/internal/web/admin_series_detail.go

#172 : three more owner-notice conditions: no-browser-route, sidecar-down, adapter-broken 28fef689ec

FaultsFrom judges three more faults at the shared twelve-hour OwnerWindow:
a no-browser-route Site's refusing run (browser-backed Sites excluded), a
sidecar no Lane has reached (one site-wide fault), and a Site where more
than half of Series hold an old no-chapter failure row. recordPass fills
the inputs from three new store reads (RefusingSince, SidecarOK,
NoChapterShare), each failing independently and never failing a pass, and
the clear loop forgets the empty-Site row too so a lifted sidecar-down
fires again on return.

#172 : floor sidecar-down's age at the window when no Lane ever reached the sidecar b58945894d

A fresh database whose browser Lanes skipped from day one has no
sidecar-reaching pass, so sidecarDownSince returned Since 0 and the notice
rendered the age since the epoch. Report the window itself: 'at least
twelve hours' is the honest floor the condition guarantees.

#172 : clear the empty-Site suppression row only for sidecar-down c655586202

Only sidecar-down ever writes a Site=='' row, so the loop's empty-Site
clear for the other three conditions was a no-op delete on every pass.
Move it out of the per-condition loop, scoped to ConditionSidecarDown.

Merge #172 : The other three conditions the rule selects a7bbeb50e5

#173 : page verdict shares FaultsFrom judgement so push and landing cannot disagree 820f57a7fa

review: fix overviewView docstring to document fail-open fault reads 8e6f4d2053

Merge #173 : The page explains every fault the message names e064a9ea09

sulthan merged commit e93e79c1bb into main

2026-08-23 11:31:11 +07:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sulthan/mangaBookmark#174