sulthan
af07314bb6
Uncommitted work from three design runs on this branch, against one design system: docs/design-system.md is updated to match the CSS, not the reverse. Library (Reader-facing): - .chrome sticks at top: 0. Search and the tab row were unreachable three screens into a 300-item library, which is exactly where they earn their keep; everything above them still scrolls away on purpose. - One :focus-visible ring (2px --paper) on the nine controls that defined none and fell back to the UA blue. .searchbar keeps its border recolour as a resting cue but no longer stands in for a ring. - Mono labels lift 10px -> 11px everywhere. The brief names night reading and glare as the usage scene; 10px small-caps was where taste overrode it. - A card in flight past 2s says "Saving..." and carries aria-busy. htmx sets neither, so the wait up to its 15s timeout was silent in both channels. - Titles clamp at 3 lines; .is-new .title takes width: fit-content, or -webkit-box stretches the ember underline past the text it sizes to. /admin: - Overview routes into Lanes when a lane is unhealthy, prefixes each figure with its column word on the phone layout that drops the thead, labels state cells for a screen reader, and has an empty state where the sites table assumed rows. - The admin shell picks up the library's chrome: htmx 15s timeout, the shared #notice slot, #sr-announce, filter.js. admin.css follows the same pass. - admin_render_test.go and card_render_test.go render the templates directly, so markup regressions in either surface fail without a browser. Login: - DISCORD_GUILD_NAME (optional) names the community on the login screen and in the refusal message, so a stranger knows which Discord to ask for an invite. Unset degrades to a generic label; neither form names the guild id. Handlers: - maxChapterNum (9999) bounds both typed-chapter paths. uiChapter and adminSeriesCorrectLatest each parsed a float64 with no ceiling, so a hand-rolled POST stored 1e308 and every later reader of that row inherited it. Matches the max on the card's chapter input. go test ./... green.
73 lines
2.8 KiB
Go
73 lines
2.8 KiB
Go
package web
|
|
|
|
import (
|
|
"html/template"
|
|
"strings"
|
|
"testing"
|
|
|
|
"bookmarkmanager/backend/internal/store"
|
|
)
|
|
|
|
// The card carries two guarantees a browser can break that Go cannot see, so
|
|
// they are asserted on the rendered markup:
|
|
//
|
|
// - the monogram is unconditional. A cover that 404s or a request the phone
|
|
// drops leaves an <img> with no bytes, and the letter underneath it is the
|
|
// only thing between that and the browser's broken-image glyph in a 93px
|
|
// slot. Rendering it only when Cover is empty covers the wrong failure.
|
|
// - the chapter field does not refuse its own value. It is pre-filled from
|
|
// LastChapterNum, which the API accepts as any float, so a step that
|
|
// quantises the field makes a series read to 1200.25 unsavable without
|
|
// first editing a number the reader did not want to change.
|
|
func TestCardRenderKeepsCoverFallbackAndAcceptsFractionalChapter(t *testing.T) {
|
|
tmpl, err := template.ParseFS(templateFS, "templates/*.html")
|
|
if err != nil {
|
|
t.Fatalf("ParseFS: %v", err)
|
|
}
|
|
b := store.Bookmark{
|
|
Key: "asura:x", Site: "asura", Title: "Chronicles", Status: store.StatusReading,
|
|
Cover: "https://bookmarks.test/covers/abc", LastChapter: "Chapter 1200.25",
|
|
LastChapterNum: 1200.25,
|
|
}
|
|
var out strings.Builder
|
|
if err := tmpl.ExecuteTemplate(&out, "card", b); err != nil {
|
|
t.Fatalf("ExecuteTemplate: %v", err)
|
|
}
|
|
got := out.String()
|
|
|
|
if !strings.Contains(got, `class="monogram"`) {
|
|
t.Error("a card with a cover rendered no monogram: a failed image has no fallback")
|
|
}
|
|
if !strings.Contains(got, `step="any"`) {
|
|
t.Error(`chapter input is not step="any": a fractional pre-filled value is unsavable`)
|
|
}
|
|
if !strings.Contains(got, `value="1200.25"`) {
|
|
t.Errorf("chapter input is not pre-filled with the stored progress:\n%s", got)
|
|
}
|
|
}
|
|
|
|
// Every failing request must land somewhere visible. A card's own writes report
|
|
// into its .error-inline; a tab switch and a credential rotation have no card,
|
|
// and #notice is the only slot filter.js can fall back to — without it in the
|
|
// shell they fail silently. The tab's own active-state move is guarded on the
|
|
// response, or a failed switch underlines a bucket the list is not showing.
|
|
func TestAppShellCarriesFailureNoticeAndGuardsTabState(t *testing.T) {
|
|
tmpl, err := template.ParseFS(templateFS, "templates/*.html")
|
|
if err != nil {
|
|
t.Fatalf("ParseFS: %v", err)
|
|
}
|
|
var out strings.Builder
|
|
view := listView{Lib: store.KindManga, Tab: "all"}
|
|
if err := tmpl.ExecuteTemplate(&out, "app", view); err != nil {
|
|
t.Fatalf("ExecuteTemplate: %v", err)
|
|
}
|
|
got := out.String()
|
|
|
|
if !strings.Contains(got, `id="notice"`) {
|
|
t.Error("no #notice in the shell: a failure with no card to sit in reports nowhere")
|
|
}
|
|
if strings.Contains(got, `hx-on::after-request="setActiveTab(this)"`) {
|
|
t.Error("a tab moves its active state unconditionally: a failed switch underlines the wrong bucket")
|
|
}
|
|
}
|