Owner Finish control on the Series detail page: confirm-gated finish, instant un-finish (#158)

backend/internal/web/admin.go

@@ -47,6 +47,8 @@ func (h *Handler) adminRoutes() []adminRoute {
 		{"GET /admin/series", h.adminSeries},
 		{"GET /admin/series/{key}", h.adminSeriesDetail},
 		{"POST /admin/series/{key}/poll", h.adminSeriesPoll},
+		{"POST /admin/series/{key}/finish", h.adminSeriesFinish},
+		{"POST /admin/series/{key}/unfinish", h.adminSeriesUnfinish},
 		{"POST /admin/series/{key}/latest", h.adminSeriesCorrectLatest},
 		{"POST /admin/series/{key}/series-url", h.adminSeriesSetURL},
 		{"POST /admin/series/{key}/remove", h.adminSeriesRemove},

backend/internal/web/admin_series.go

@@ -110,6 +110,11 @@ type seriesRowView struct {
 	// raced answer: the row stays and says a fresh Bookmark caught the press.
 	CanRemove      bool
 	RemovalRefused bool
+	// Finished is the row's display of the owner's finish stamp: the list row
+	// shows the state and never offers the control — that lives on the detail
+	// page, where a press that retires a Series from the Lane is on purpose
+	// and confirm-gated (issue #158).
+	Finished bool
 }
 
 // adminSeries renders the filterable, bookmarkable Series list: filter, Site,
@@ -182,6 +187,96 @@ func (h *Handler) adminSeriesPoll(w http.ResponseWriter, r *http.Request) {
 	h.render(w, http.StatusOK, "series-row", seriesRow(a, band, time.Now()))
 }
 
+// adminSeriesFinish is the owner's Finish control: it stamps the Series'
+// finished_at and answers with the freshly rendered meta fragment, so the
+// "finished <age> ago" line describes the state after the press. The Lane's
+// next pass reads the stamp and stops polling the Series (issue #157). The
+// owner gate is the route's, not this handler's; the body is capped like the
+// API path caps its bodies; the key is validated here — a malformed key is a
+// 400 and an unknown one a 404.
+func (h *Handler) adminSeriesFinish(w http.ResponseWriter, r *http.Request) {
+	site, seriesID, ok := strings.Cut(r.PathValue("key"), ":")
+	if !ok || site == "" || seriesID == "" {
+		http.Error(w, "bad series key", http.StatusBadRequest)
+		return
+	}
+	r.Body = http.MaxBytesReader(w, r.Body, 1<<16)
+	if err := r.ParseForm(); err != nil {
+		http.Error(w, "invalid form", http.StatusBadRequest)
+		return
+	}
+	if _, found, err := h.adminSeriesByKey(site, seriesID); err != nil {
+		log.Printf("series finish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	} else if !found {
+		http.NotFound(w, r)
+		return
+	}
+	if err := h.store.SetSeriesFinished(site, seriesID, time.Now().UnixMilli()); err != nil {
+		log.Printf("series finish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	// Re-read after the stamp: the answer must describe the state after the
+	// press, so the line reads "finished just now". The control's one caller
+	// is the detail page, which swaps the meta fragment in place.
+	a, found, err := h.adminSeriesByKey(site, seriesID)
+	if err != nil {
+		log.Printf("series finish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	if !found {
+		http.NotFound(w, r)
+		return
+	}
+	h.render(w, http.StatusOK, "series-detail-meta", h.seriesDetailView(a))
+}
+
+// adminSeriesUnfinish is the reversal of the Finish control: it clears the
+// stamp (writes zero) and answers with the freshly rendered meta fragment, so
+// the Series is back in the Lane's queue from its next pass. Reversal, so it
+// fires instantly with no confirm row (issue #158).
+func (h *Handler) adminSeriesUnfinish(w http.ResponseWriter, r *http.Request) {
+	site, seriesID, ok := strings.Cut(r.PathValue("key"), ":")
+	if !ok || site == "" || seriesID == "" {
+		http.Error(w, "bad series key", http.StatusBadRequest)
+		return
+	}
+	r.Body = http.MaxBytesReader(w, r.Body, 1<<16)
+	if err := r.ParseForm(); err != nil {
+		http.Error(w, "invalid form", http.StatusBadRequest)
+		return
+	}
+	if _, found, err := h.adminSeriesByKey(site, seriesID); err != nil {
+		log.Printf("series unfinish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	} else if !found {
+		http.NotFound(w, r)
+		return
+	}
+	if err := h.store.SetSeriesFinished(site, seriesID, 0); err != nil {
+		log.Printf("series unfinish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	// Re-read after the write: the answer must describe the state after the
+	// press, so the fragment no longer carries the finished line.
+	a, found, err := h.adminSeriesByKey(site, seriesID)
+	if err != nil {
+		log.Printf("series unfinish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	if !found {
+		http.NotFound(w, r)
+		return
+	}
+	h.render(w, http.StatusOK, "series-detail-meta", h.seriesDetailView(a))
+}
+
 // adminSeriesCorrectLatest is the Latest Chapter correction: the owner types
 // one number and the Series' Latest Chapter becomes it, stamped as a
 // Correction. The number must be a finite float greater than zero — a
@@ -475,8 +570,6 @@ func (h *Handler) seriesListView(r *http.Request) (seriesListView, error) {
 	if err != nil {
 		return seriesListView{}, err
 	}
-	// A page past the end is not an empty list: the store's window count runs
-	// over the rows the result set carries, so an overflow page reports zero
 	// rows and zero total, and the list re-reads at page 1 to know the truth.
 	if len(data.Rows) == 0 && page > 1 {
 		page = 1
@@ -572,6 +665,7 @@ func seriesRow(a store.AdminSeries, i int, now time.Time) seriesRowView {
 		CanRemove: a.ReaderCount == 0,
 		Pending:   pending,
 		Requested: requested,
+		Finished:  a.FinishedAt > 0,
 	}
 	if a.LatestChapterNum != nil {
 		row.Ch = strconv.FormatFloat(*a.LatestChapterNum, 'f', -1, 64)

backend/internal/web/admin_series_detail.go

@@ -56,6 +56,14 @@ type seriesDetailView struct {
 	// Series no Reader holds can be removed, so the owner is never offered a
 	// button the database will always refuse.
 	CanRemove bool
+	// Finished is the owner's finish stamp rendered for the control: while it
+	// stands, the page offers the instant Un-finish, not the confirm-gated
+	// Finish (issue #158).
+	Finished bool
+	// FinishedSince is the "finished <age> ago" line, "" while no finish
+	// stands. It rides the meta fragment both presses swap, so the answer
+	// itself shows how long the Series has been finished.
+	FinishedSince string
 }
 
 // adminSeriesDetail renders one Series' page, keyed by the composite
@@ -141,6 +149,8 @@ func (h *Handler) seriesDetailView(a store.AdminSeries) seriesDetailView {
 		v.Checked = since(time.Now(), time.UnixMilli(a.LatestCheckedAt))
 	}
 	v.Corrected = correctedAge(time.Now(), a.LatestCorrectedAt)
+	v.Finished = a.FinishedAt != 0
+	v.FinishedSince = finishedAge(time.Now(), a.FinishedAt)
 
 	// Provenance: the actor class behind the current number, evaluated in the
 	// order the classes outrank one another — the owner's stamp, which a
@@ -171,3 +181,13 @@ func correctedAge(now time.Time, at int64) string {
 	}
 	return "corrected " + since(now, time.UnixMilli(at))
 }
+
+// finishedAge is the finish marker's text: "finished <age> ago" while the
+// stamp is set, "" when zero — zero means never finished, and the reversal
+// (un-finish) must not read as history after a press (issue #158).
+func finishedAge(now time.Time, at int64) string {
+	if at == 0 {
+		return ""
+	}
+	return "finished " + since(now, time.UnixMilli(at))
+}

backend/internal/web/static/admin.css

@@ -653,6 +653,22 @@
   margin-left: auto;
 }
 
+/* The finish confirm is the one calm row on the admin sheet: a reversible
+   move wears the recessed ash, never the remove wash above, and its
+   affirmative takes the sheet's patina accent (issue #158). */
+.admin-sheet .confirm-row.calm {
+  background: var(--ash);
+}
+
+.admin-sheet .confirm-row.calm span {
+  color: var(--paper-dim);
+}
+
+.admin-sheet .confirm-row.calm .go {
+  background: var(--patina);
+  color: var(--ink);
+}
+
 .admin-sheet .tbl.series .row-msg {
   grid-column: 1 / -1;
   margin-top: 6px;

backend/internal/web/templates/series-detail.html

@@ -39,6 +39,22 @@
   <div class="field"><button class="ghost danger" hx-post="/admin/series/{{.Key}}/remove" hx-target="#detail-meta" hx-confirm="Removes this series and its stored cover. No Reader has it bookmarked; one re-bookmarking it recreates the row.">Remove</button></div>
 </div>
 {{end}}
+{{if .Finished}}
+<div class="dform">
+  <div class="field"><button type="button" class="ghost" hx-post="/admin/series/{{.Key}}/unfinish" hx-target="#detail-meta" hx-swap="outerHTML">Un-finish</button></div>
+</div>
+{{else}}
+<div class="dform">
+  <div class="field"><button type="button" class="ghost" onclick="document.getElementById('confirm-finish').hidden = false">Finish</button></div>
+  <div class="confirm-row calm" id="confirm-finish" role="group" aria-live="polite" hidden>
+    <span>Mark this Series finished?</span>
+    <div>
+      <button type="button" class="go" hx-post="/admin/series/{{.Key}}/finish" hx-target="#detail-meta" hx-swap="outerHTML">Finish</button>
+      <button type="button" onclick="document.getElementById('confirm-finish').hidden = true">Cancel</button>
+    </div>
+  </div>
+</div>
+{{end}}
 {{end}}
 
 {{/* series-detail-meta is the meta line, and the answer a Check now or
@@ -54,6 +70,7 @@
   <span>{{.Readers}} readers</span>
   {{if .Corrected}}<span class="mark">{{.Corrected}}</span>{{end}}
   {{if .Pending}}<span class="mark">{{.Requested}}</span>{{end}}
+  {{if .FinishedSince}}<span class="mark">{{.FinishedSince}}</span>{{end}}
   {{if .Unpollable}}<span class="mark">unpollable</span>{{end}}
   {{if .NoCover}}<span class="mark">no cover</span>{{end}}
   {{if .Orphan}}<span class="mark">orphan</span>{{end}}

backend/internal/web/templates/series-list.html

@@ -47,7 +47,7 @@
   <span class="c-ch">{{.Ch}}</span>
   <span>{{.Age}}</span>
   <span class="c-rd">{{.Readers}}</span>
-  <span class="c-note">{{range .Notes}}<span class="mark">{{.}}</span>{{end}}{{if .More}}<span class="mark mark-faint">+{{.More}}</span>{{end}}</span>
+  <span class="c-note">{{range .Notes}}<span class="mark">{{.}}</span>{{end}}{{if .More}}<span class="mark mark-faint">+{{.More}}</span>{{end}}{{if .Finished}}<span class="mark mark-faint">finished</span>{{end}}</span>
   <span class="c-act">{{if .CanPoll}}<a class="ghost act" hx-post="/admin/series/{{.Key}}/poll" hx-target="closest .trow" hx-swap="outerHTML" hx-vals='{"band":{{if .Band}}1{{else}}0{{end}}}' href="#">Check now</a>{{end}}{{if .CanRemove}}<button class="ghost danger" hx-post="/admin/series/{{.Key}}/remove" hx-target="closest .trow" hx-swap="outerHTML" hx-include="#filterbar" hx-vals='{"band":{{if .Band}}1{{else}}0{{end}}}' hx-confirm="Removes this series and its stored cover. No Reader has it bookmarked; one re-bookmarking it recreates the row.">Remove</button>{{end}}</span>
   {{if .RemovalRefused}}<span class="row-msg">a Reader has bookmarked this Series again</span>{{end}}
 </div>