Spec #136: Finished belongs to the Series — owner-owned poll gate, Lifecycle bucket dropped (#163)

Closes #136.

Spec #136 end to end: `finished` becomes a fact about the Series, written only by the owner, and the reader-facing Lifecycle bucket is gone.

## What landed

- **#157** — `series.finished_at bigint NOT NULL DEFAULT 0` plus the migration whose statement order is load-bearing (seed from the buckets, then flip them); both Lane queries lose the `HAVING COUNT(*) FILTER (WHERE b.status <> 'finished')` clause and gate on `finished_at = 0` instead, with the due-query/eligible-count force asymmetry kept deliberate and commented; `StatusFinished`, its API special-case 400, the web tab and the templates' Finished bucket deleted.
- **#158** — owner Finish control on the Series detail page: confirm-gated finish, instant un-finish, admin accent (never ember, nothing is destroyed), `Store.SetSeriesFinished`, the two routes behind the owner gate, and the state displayed on the list row without offering the control there.
- **#160** — reader side: derived `finished` bool on the flat Bookmark (`s.finished_at > 0`), rendered as a text-only label in both userscripts and on the web card; read-only inbound by omission from `Upsert`'s explicit `series` column list, same mechanism that already protects `cover`.
- **#161** — glossary and the stale Reader-count divergence note catch up.
- **#159** — `finished` joins the admin filter vocabulary (predicate `finished_at > 0`, label `Finished`, own aggregate count, figure last in the stats block as informational); the four clock-driven hygiene predicates (stale, never-checked, no-cover, no-chapter) exclude finished Series while unpollable, orphan and sighting-raised deliberately do not.

## Verification

`go vet ./...` and `go test ./...` green on the merged branch (Docker-backed, throwaway `postgres:17-alpine` per package). Each ticket also passed a two-axis review (spec + standards) on its own branch before merge.

Reviewed-on: #163
Co-authored-by: Sulthan Zaki <sultankiki05@gmail.com>
Co-committed-by: Sulthan Zaki <sultankiki05@gmail.com>

backend/internal/web/admin.go

@@ -47,6 +47,8 @@ func (h *Handler) adminRoutes() []adminRoute {
 		{"GET /admin/series", h.adminSeries},
 		{"GET /admin/series/{key}", h.adminSeriesDetail},
 		{"POST /admin/series/{key}/poll", h.adminSeriesPoll},
+		{"POST /admin/series/{key}/finish", h.adminSeriesFinish},
+		{"POST /admin/series/{key}/unfinish", h.adminSeriesUnfinish},
 		{"POST /admin/series/{key}/latest", h.adminSeriesCorrectLatest},
 		{"POST /admin/series/{key}/series-url", h.adminSeriesSetURL},
 		{"POST /admin/series/{key}/remove", h.adminSeriesRemove},

backend/internal/web/admin_overview.go

@@ -24,8 +24,9 @@ type overviewView struct {
 	// its own filter, and the verdict wants the inclusive number.
 	Unchecked int
 	// Hygiene is the seven problem filters in the Series list's own render
-	// order; Library is the library split plus the roster. Every figure is a
-	// door into the list that counts it, except a zero.
+	// order plus the finished figure riding last (informational); Library is
+	// the library split plus the roster. Every figure is a door into the list
+	// that counts it, except a zero.
 	Hygiene []fig
 	Library []fig
 	// Sites is the per-Site library shape table, one row per Site with any
@@ -59,7 +60,7 @@ type siteRow struct {
 }
 
 // overviewView assembles the landing page from the store's read model: one
-// SeriesShapes pass per filter summed in Go (the shipped surface offers eight
+// SeriesShapes pass per filter summed in Go (the shipped surface offers nine
 // grouped passes, not a stats query — #140), the pass log's latest pass per
 // Site, and the roster. A failure in any read is a 500 with a logged reason,
 // never a page of silent zeroes.
@@ -93,8 +94,10 @@ func (h *Handler) overviewView() (overviewView, error) {
 	view.Unchecked = totals[store.SeriesFilterStale] + totals[store.SeriesFilterNeverChecked]
 	view.Verdict, view.HasCounts = overviewVerdict(passes, now)
 
-	// The seven problem filters, in seriesFilterOrder's permanent-then-fixable
-	// order; the All filter's count belongs to the Library block, not to a
+	// The hygiene figures, in seriesFilterOrder's tail: the seven problem
+	// filters in permanent-then-fixable order, then the finished figure last —
+	// informational, not a problem, and last because seriesFilterOrder appends
+	// it there. The All filter's count belongs to the Library block, not to a
 	// "hygiene" figure.
 	hygiene := make([]fig, 0, len(seriesFilterOrder)-1)
 	for _, name := range seriesFilterOrder[1:] {

backend/internal/web/admin_series.go

@@ -20,10 +20,10 @@ import (
 // the wrong page. The store does not export it (#140).
 const seriesPageSize = 50
 
-// seriesFilterLabels names every hygiene filter for the Series list select,
-// keyed by the wire constant the URL carries. The render order is
-// seriesFilterOrder; the labels are read by later admin tickets too, so the
-// map and the constants cannot drift apart.
+// seriesFilterLabels names every Series filter for the list select, keyed by
+// the wire constant the URL carries. The render order is seriesFilterOrder;
+// the labels are read by later admin tickets too, so the map and the
+// constants cannot drift apart.
 var seriesFilterLabels = map[string]string{
 	store.SeriesFilterAll:          "All series",
 	store.SeriesFilterNoURL:        "No series URL",
@@ -33,10 +33,13 @@ var seriesFilterLabels = map[string]string{
 	store.SeriesFilterStale:        "Not checked in 12h",
 	store.SeriesFilterNoCover:      "No cover",
 	store.SeriesFilterReaderReport: "Latest from a Reader",
+	store.SeriesFilterFinished:     "Finished",
 }
 
 // seriesFilterOrder is the select's render order: All first, then the
-// permanent repairs, then the fixable ones (issue #140).
+// permanent repairs, then the fixable ones (issue #140). Finished rides the
+// tail, last — deliberate, not a repair — and the Overview's stats block
+// renders the same tail, which is what sits the finished figure last there.
 var seriesFilterOrder = []string{
 	store.SeriesFilterAll,
 	store.SeriesFilterNoURL,
@@ -46,6 +49,7 @@ var seriesFilterOrder = []string{
 	store.SeriesFilterStale,
 	store.SeriesFilterNoCover,
 	store.SeriesFilterReaderReport,
+	store.SeriesFilterFinished,
 }
 
 // seriesListView is the Series list page's data. The template renders strings
@@ -110,6 +114,11 @@ type seriesRowView struct {
 	// raced answer: the row stays and says a fresh Bookmark caught the press.
 	CanRemove      bool
 	RemovalRefused bool
+	// Finished is the row's display of the owner's finish stamp: the list row
+	// shows the state and never offers the control — that lives on the detail
+	// page, where a press that retires a Series from the Lane is on purpose
+	// and confirm-gated (issue #158).
+	Finished bool
 }
 
 // adminSeries renders the filterable, bookmarkable Series list: filter, Site,
@@ -182,6 +191,96 @@ func (h *Handler) adminSeriesPoll(w http.ResponseWriter, r *http.Request) {
 	h.render(w, http.StatusOK, "series-row", seriesRow(a, band, time.Now()))
 }
 
+// adminSeriesFinish is the owner's Finish control: it stamps the Series'
+// finished_at and answers with the freshly rendered meta fragment, so the
+// "finished <age> ago" line describes the state after the press. The Lane's
+// next pass reads the stamp and stops polling the Series (issue #157). The
+// owner gate is the route's, not this handler's; the body is capped like the
+// API path caps its bodies; the key is validated here — a malformed key is a
+// 400 and an unknown one a 404.
+func (h *Handler) adminSeriesFinish(w http.ResponseWriter, r *http.Request) {
+	site, seriesID, ok := strings.Cut(r.PathValue("key"), ":")
+	if !ok || site == "" || seriesID == "" {
+		http.Error(w, "bad series key", http.StatusBadRequest)
+		return
+	}
+	r.Body = http.MaxBytesReader(w, r.Body, 1<<16)
+	if err := r.ParseForm(); err != nil {
+		http.Error(w, "invalid form", http.StatusBadRequest)
+		return
+	}
+	if _, found, err := h.adminSeriesByKey(site, seriesID); err != nil {
+		log.Printf("series finish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	} else if !found {
+		http.NotFound(w, r)
+		return
+	}
+	if err := h.store.SetSeriesFinished(site, seriesID, time.Now().UnixMilli()); err != nil {
+		log.Printf("series finish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	// Re-read after the stamp: the answer must describe the state after the
+	// press, so the line reads "finished just now". The control's one caller
+	// is the detail page, which swaps the meta fragment in place.
+	a, found, err := h.adminSeriesByKey(site, seriesID)
+	if err != nil {
+		log.Printf("series finish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	if !found {
+		http.NotFound(w, r)
+		return
+	}
+	h.render(w, http.StatusOK, "series-detail-meta", h.seriesDetailView(a))
+}
+
+// adminSeriesUnfinish is the reversal of the Finish control: it clears the
+// stamp (writes zero) and answers with the freshly rendered meta fragment, so
+// the Series is back in the Lane's queue from its next pass. Reversal, so it
+// fires instantly with no confirm row (issue #158).
+func (h *Handler) adminSeriesUnfinish(w http.ResponseWriter, r *http.Request) {
+	site, seriesID, ok := strings.Cut(r.PathValue("key"), ":")
+	if !ok || site == "" || seriesID == "" {
+		http.Error(w, "bad series key", http.StatusBadRequest)
+		return
+	}
+	r.Body = http.MaxBytesReader(w, r.Body, 1<<16)
+	if err := r.ParseForm(); err != nil {
+		http.Error(w, "invalid form", http.StatusBadRequest)
+		return
+	}
+	if _, found, err := h.adminSeriesByKey(site, seriesID); err != nil {
+		log.Printf("series unfinish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	} else if !found {
+		http.NotFound(w, r)
+		return
+	}
+	if err := h.store.SetSeriesFinished(site, seriesID, 0); err != nil {
+		log.Printf("series unfinish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	// Re-read after the write: the answer must describe the state after the
+	// press, so the fragment no longer carries the finished line.
+	a, found, err := h.adminSeriesByKey(site, seriesID)
+	if err != nil {
+		log.Printf("series unfinish %s: %v", site+":"+seriesID, err)
+		http.Error(w, "internal error", http.StatusInternalServerError)
+		return
+	}
+	if !found {
+		http.NotFound(w, r)
+		return
+	}
+	h.render(w, http.StatusOK, "series-detail-meta", h.seriesDetailView(a))
+}
+
 // adminSeriesCorrectLatest is the Latest Chapter correction: the owner types
 // one number and the Series' Latest Chapter becomes it, stamped as a
 // Correction. The number must be a finite float greater than zero — a
@@ -516,9 +615,9 @@ func (h *Handler) seriesListView(r *http.Request) (seriesListView, error) {
 	return view, nil
 }
 
-// seriesFilterOptions renders every hygiene filter with its library-wide
-// count, one SeriesShapes pass per filter summed in Go — the shipped surface
-// offers eight grouped passes, not a single stats query (#140). The counts
+// seriesFilterOptions renders every filter with its library-wide count, one
+// SeriesShapes pass per filter summed in Go — the shipped surface offers nine
+// grouped passes, not a single stats query (#140). The counts
 // are library-wide because the select sits next to the Site narrowing and
 // must not shift as the owner narrows the list itself. Cutoff travels with
 // the stale filter, or its count would always be zero.
@@ -572,6 +671,7 @@ func seriesRow(a store.AdminSeries, i int, now time.Time) seriesRowView {
 		CanRemove: a.ReaderCount == 0,
 		Pending:   pending,
 		Requested: requested,
+		Finished:  a.FinishedAt > 0,
 	}
 	if a.LatestChapterNum != nil {
 		row.Ch = strconv.FormatFloat(*a.LatestChapterNum, 'f', -1, 64)

backend/internal/web/admin_series_detail.go

@@ -56,6 +56,14 @@ type seriesDetailView struct {
 	// Series no Reader holds can be removed, so the owner is never offered a
 	// button the database will always refuse.
 	CanRemove bool
+	// Finished is the owner's finish stamp rendered for the control: while it
+	// stands, the page offers the instant Un-finish, not the confirm-gated
+	// Finish (issue #158).
+	Finished bool
+	// FinishedSince is the "finished <age> ago" line, "" while no finish
+	// stands. It rides the meta fragment both presses swap, so the answer
+	// itself shows how long the Series has been finished.
+	FinishedSince string
 }
 
 // adminSeriesDetail renders one Series' page, keyed by the composite
@@ -141,6 +149,8 @@ func (h *Handler) seriesDetailView(a store.AdminSeries) seriesDetailView {
 		v.Checked = since(time.Now(), time.UnixMilli(a.LatestCheckedAt))
 	}
 	v.Corrected = correctedAge(time.Now(), a.LatestCorrectedAt)
+	v.Finished = a.FinishedAt != 0
+	v.FinishedSince = finishedAge(time.Now(), a.FinishedAt)
 
 	// Provenance: the actor class behind the current number, evaluated in the
 	// order the classes outrank one another — the owner's stamp, which a
@@ -171,3 +181,13 @@ func correctedAge(now time.Time, at int64) string {
 	}
 	return "corrected " + since(now, time.UnixMilli(at))
 }
+
+// finishedAge is the finish marker's text: "finished <age> ago" while the
+// stamp is set, "" when zero — zero means never finished, and the reversal
+// (un-finish) must not read as history after a press (issue #158).
+func finishedAge(now time.Time, at int64) string {
+	if at == 0 {
+		return ""
+	}
+	return "finished " + since(now, time.UnixMilli(at))
+}

backend/internal/web/static/admin.css

@@ -653,6 +653,22 @@
   margin-left: auto;
 }
 
+/* The finish confirm is the one calm row on the admin sheet: a reversible
+   move wears the recessed ash, never the remove wash above, and its
+   affirmative takes the sheet's patina accent (issue #158). */
+.admin-sheet .confirm-row.calm {
+  background: var(--ash);
+}
+
+.admin-sheet .confirm-row.calm span {
+  color: var(--paper-dim);
+}
+
+.admin-sheet .confirm-row.calm .go {
+  background: var(--patina);
+  color: var(--ink);
+}
+
 .admin-sheet .tbl.series .row-msg {
   grid-column: 1 / -1;
   margin-top: 6px;

backend/internal/web/static/filter.js

@@ -61,7 +61,7 @@ function setActiveTab(el) {
   document.dispatchEvent(new Event("bmgr:refilter"));
 }
 
-// The chapter-edit form and the archive/finish/remove confirm rows are the
+// The chapter-edit form and the archive/remove confirm rows are the
 // per-card disclosure panels; only one makes sense open at a time. The button
 // that owns an open panel carries .open, which is how the strip shows which
 // cell the panel belongs to.
@@ -97,10 +97,10 @@ function toggleChapterForm(key) {
   if (form && !form.hidden) form.querySelector("input").focus();
 }
 
-// kind is "archive" | "finish" | "remove" — the panel id and the owning action
+// kind is "archive" | "remove" — the panel id and the owning action
 // cell share it.
 function toggleConfirmRow(key, kind) {
-  var cls = { archive: ".box", finish: ".finish", remove: ".remove" }[kind];
+  var cls = { archive: ".box", remove: ".remove" }[kind];
   var row = togglePanel(key, "confirm-" + kind + "-" + key, ".actions " + cls);
   // Focus the answer rather than trusting aria-live on a container that merely
   // unhides: it makes the announcement deterministic, keeps tab order inside

backend/internal/web/static/style.css

@@ -54,7 +54,7 @@
 
   --ink: #100f0e;          /* page */
   --ash: #161413;          /* recessed panel (chapter form) */
-  --dim: #0d0c0b;          /* archived / finished rows sink */
+  --dim: #0d0c0b;          /* archived rows sink */
   --rule: #221f1d;         /* hairline between sheets */
   --rule-soft: #1a1817;    /* measure edges */
   --field-line: #2c2926;
@@ -550,6 +550,7 @@ button { cursor: pointer; }
 .new-chapter { color: var(--ember); }
 .state { display: flex; align-items: center; gap: 4px; color: var(--mute); }
 .state svg { width: 10px; height: 10px; }
+.state.finished { color: var(--moss); }
 .is-dim .meta { color: var(--mute-2); }
 .is-dim .site-asura, .is-dim .site-demonic,
 .is-dim .site-comix, .is-dim .site-kagane,
@@ -612,13 +613,13 @@ button { cursor: pointer; }
 .actions > *:last-child { border-right: none; }
 .actions svg { width: 17px; height: 17px; }
 .actions > *:hover { color: var(--paper); }
-/* Per-action accent on hover and press: gold favourite, slate archive, moss
-   finished, clay chapter. Remove keeps --danger, play keeps paper/ember. */
+/* Per-action accent on hover and press: gold favourite, slate archive, clay
+   chapter. Remove keeps --danger, play keeps paper/ember. */
 .actions .fav:hover, .actions .fav:active, .actions .fav:focus-visible { color: var(--brass); }
 .actions .pencil:hover, .actions .pencil:active, .actions .pencil:focus-visible { color: var(--clay); }
 .actions .box:hover, .actions .box:active, .actions .box:focus-visible { color: var(--slate); }
-.actions .finish:hover, .actions .finish:active, .actions .finish:focus-visible { color: var(--moss); }
 .actions .play { color: var(--paper); }
+
 .is-new .actions .play { color: var(--ember); }
 .actions .play:hover { background: var(--hover); }
 .actions .on { color: var(--brass); }
@@ -632,8 +633,8 @@ button { cursor: pointer; }
 .actions .remove.open { background: var(--danger-wash); color: var(--danger); }
 .is-dim .actions > * { color: var(--mute-2); }
 
-/* Three clusters by consequence: navigate (play) | organize (favourite,
-   chapter) | lifecycle (archive/restore, finish, remove). The lifecycle cells
+/* Two clusters by consequence: navigate (play) | organize (favourite,
+   chapter) | lifecycle (archive/restore, remove). The lifecycle cells
    sit on a recessed ground so the thumb reads "this one moves the series"
    before it reads which icon it landed on. */
 .actions > .lifecycle { background: var(--ash); }
@@ -712,7 +713,7 @@ button { cursor: pointer; }
   color: var(--danger-ink);
   font-weight: 600;
 }
-/* Archive and finish are reversible, so their confirm asks in grey — only the
+/* Archive is reversible, so its confirm asks in grey — only the
    irreversible remove gets the danger wash. */
 .confirm-row.calm { background: var(--ash); }
 .confirm-row.calm span { color: var(--paper-dim); }
@@ -917,9 +918,7 @@ button { cursor: pointer; }
   /* The cell border follows the icon on hover, so the accent reads as a state
      rather than a stray colour. */
   .actions .fav:hover, .actions .pencil:hover,
-  .actions .box:hover, .actions .finish:hover { border-color: currentColor; }
-
-  /* Panels line up with the body text, i.e. past the cover and its gap. */
+  .actions .box:hover { border-color: currentColor; }
   .chapter-form, .confirm-row, .error-inline {
     margin-left: calc(var(--cover-w) + var(--row-gap));
   }

backend/internal/web/templates/app.html

@@ -71,10 +71,6 @@
        {{if eq .Tab "archived"}}aria-current="page"{{end}}
        hx-get="{{.ListURL "archived"}}" hx-target="#list" hx-swap="innerHTML"
        hx-push-url="{{.PageURL "archived"}}" hx-on::after-request="setActiveTab(this)">Archived</a>
-    <a href="{{.PageURL "finished"}}" class="{{if eq .Tab "finished"}}active{{end}}"
-       {{if eq .Tab "finished"}}aria-current="page"{{end}}
-       hx-get="{{.ListURL "finished"}}" hx-target="#list" hx-swap="innerHTML"
-       hx-push-url="{{.PageURL "finished"}}" hx-on::after-request="setActiveTab(this)">Finished</a>
   </nav>
   </div>
 

backend/internal/web/templates/card.html

@@ -1,6 +1,6 @@
 {{define "card"}}
 {{/* One sheet per series. is-new turns the title crimson over an ember rule;
-     is-dim sinks archived and finished rows into italic grey. */}}
+     is-dim sinks archived rows into italic grey. */}}
 <article class="card{{if eq .Status "reading"}}{{if .HasNewChapter}} is-new{{end}}{{else}} is-dim{{end}}"
          id="card-{{.Key}}" data-title="{{.Title}}">
   <div class="row">
@@ -32,9 +32,10 @@
         {{if eq .Status "archived"}}
         <span class="sep">/</span>
         <span class="state">archived</span>
-        {{else if eq .Status "finished"}}
+        {{end}}
+        {{if .Finished}}
         <span class="sep">/</span>
-        <span class="state"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-check"/></svg>finished</span>
+        <span class="state finished">finished</span>
         {{end}}
       </p>
     </div>
@@ -56,7 +57,7 @@
         <svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-pencil"/></svg>
       </button>
       {{/* Restore is a reversal, so it fires straight away; every move *out* of
-           the list (archive, finish, remove) goes through a confirm row. */}}
+           the list (archive, remove) goes through a confirm row. */}}
       {{if eq .Status "reading"}}
       <button class="lifecycle box" title="Archive" aria-label="Archive"
               aria-expanded="false" aria-controls="confirm-archive-{{.Key}}"
@@ -71,13 +72,6 @@
         <svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-undo"/></svg>
       </button>
       {{end}}
-      {{if ne .Status "finished"}}
-      <button class="lifecycle finish" title="Mark finished" aria-label="Mark finished"
-              aria-expanded="false" aria-controls="confirm-finish-{{.Key}}"
-              onclick="toggleConfirmRow('{{.Key}}', 'finish')">
-        <svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-check"/></svg>
-      </button>
-      {{end}}
       <button class="lifecycle remove" title="Remove" aria-label="Remove"
               aria-expanded="false" aria-controls="confirm-remove-{{.Key}}"
               onclick="toggleConfirmRow('{{.Key}}', 'remove')">
@@ -116,18 +110,6 @@
     </div>
   </div>
   {{end}}
-  {{if ne .Status "finished"}}
-  <div class="confirm-row calm" id="confirm-finish-{{.Key}}" role="group" aria-live="polite" hidden>
-    <span>Mark finished?</span>
-    <div>
-      <button class="go"
-              hx-post="/ui/bookmarks/{{.Key}}/status" hx-vals='{"status":"finished"}'
-              hx-target="[id='card-{{.Key}}']" hx-swap="outerHTML"
-              hx-indicator="[id='card-{{.Key}}']" hx-disabled-elt="this">Finish</button>
-      <button type="button" onclick="toggleConfirmRow('{{.Key}}', 'finish')">Cancel</button>
-    </div>
-  </div>
-  {{end}}
   <div class="confirm-row" id="confirm-remove-{{.Key}}" role="group" aria-live="polite" hidden>
     <span>Remove “{{.Title}}”? Chapter progress is lost.</span>
     <div>

backend/internal/web/templates/chrome.html

@@ -29,21 +29,17 @@
 
 {{/* The action key. The icon strip on a card is unlabelled, so one permanent
      line under the tabs names every glyph. It follows the tab rather than the
-     row: the archived and finished buckets swap Archive for Restore, and a
-     finished series has no Done to offer. */}}
+     row: the archived bucket swaps Archive for Restore. */}}
 {{define "keyrow"}}
 <div class="keyrow" id="keyrow" aria-label="Action key"{{if .OOB}} hx-swap-oob="true"{{end}}>
   <span class="pair"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-play"/></svg><span>Read</span></span>
   <span class="pair brass"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-star"/></svg><span>Fav</span></span>
   <span class="pair"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-pencil"/></svg><span>Chapter</span></span>
-  {{if or (eq .Tab "archived") (eq .Tab "finished")}}
+  {{if eq .Tab "archived"}}
   <span class="pair"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-undo"/></svg><span>Restore</span></span>
   {{else}}
   <span class="pair"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-box"/></svg><span>Archive</span></span>
   {{end}}
-  {{if ne .Tab "finished"}}
-  <span class="pair"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-check"/></svg><span>Done</span></span>
-  {{end}}
   <span class="pair trash"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="#i-trash"/></svg><span>Delete</span></span>
 </div>
 {{end}}

backend/internal/web/templates/icons.html

@@ -7,7 +7,6 @@
   <symbol id="i-star-on" viewBox="0 0 24 24"><path d="M12 3.6l2.6 5.6 6 .8-4.4 4.2 1.1 6-5.3-2.9-5.3 2.9 1.1-6-4.4-4.2 6-.8z" fill="currentColor" stroke="currentColor" stroke-width="1.7" stroke-linejoin="round"/></symbol>
   <symbol id="i-pencil" viewBox="0 0 24 24"><path d="M4 20h4L19 9l-4-4L4 16z" fill="none" stroke="currentColor" stroke-width="1.7" stroke-linejoin="round"/></symbol>
   <symbol id="i-box" viewBox="0 0 24 24"><path d="M3 7h18v4H3zM5 11v9h14v-9M10 15h4" fill="none" stroke="currentColor" stroke-width="1.7" stroke-linejoin="round"/></symbol>
-  <symbol id="i-check" viewBox="0 0 24 24"><path d="M4 12.5l5.2 5.5L20 6.5" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/></symbol>
   <symbol id="i-trash" viewBox="0 0 24 24"><path d="M4 7h16M9.5 7V4h5v3M6.5 7l1 13h9l1-13M10.5 11v6M13.5 11v6" fill="none" stroke="currentColor" stroke-width="1.7" stroke-linecap="round"/></symbol>
   <symbol id="i-undo" viewBox="0 0 24 24"><path d="M4 9h9.5a5 5 0 010 10H8M4 9l4.2-4.2M4 9l4.2 4.2" fill="none" stroke="currentColor" stroke-width="1.7" stroke-linecap="round" stroke-linejoin="round"/></symbol>
   <symbol id="i-search" viewBox="0 0 24 24"><circle cx="10.5" cy="10.5" r="6.5" fill="none" stroke="currentColor" stroke-width="1.8"/><path d="M15.3 15.3L20 20" fill="none" stroke="currentColor" stroke-width="1.8" stroke-linecap="round"/></symbol>

backend/internal/web/templates/list.html

@@ -14,8 +14,6 @@
   <div class="empty"><strong>Nothing new.</strong><p>Every series is caught up to its latest chapter.</p></div>
 {{else if eq .Tab "archived"}}
   <div class="empty"><strong>Nothing archived.</strong><p>Shelve a series to park it here — it keeps getting checked for new chapters.</p></div>
-{{else if eq .Tab "finished"}}
-  <div class="empty"><strong>Nothing finished yet.</strong><p>Mark a series finished and it moves out of your reading list.</p></div>
 {{else if .EmptyLibrary}}
   {{/* Nothing in either library, so the links are the only thing this page can
        usefully say. Both scripts: the two libraries are separate installs. */}}

backend/internal/web/templates/series-detail.html

@@ -39,6 +39,22 @@
   <div class="field"><button class="ghost danger" hx-post="/admin/series/{{.Key}}/remove" hx-target="#detail-meta" hx-confirm="Removes this series and its stored cover. No Reader has it bookmarked; one re-bookmarking it recreates the row.">Remove</button></div>
 </div>
 {{end}}
+{{if .Finished}}
+<div class="dform">
+  <div class="field"><button type="button" class="ghost" hx-post="/admin/series/{{.Key}}/unfinish" hx-target="#detail-meta" hx-swap="outerHTML">Un-finish</button></div>
+</div>
+{{else}}
+<div class="dform">
+  <div class="field"><button type="button" class="ghost" onclick="document.getElementById('confirm-finish').hidden = false">Finish</button></div>
+  <div class="confirm-row calm" id="confirm-finish" role="group" aria-live="polite" hidden>
+    <span>Mark this Series finished?</span>
+    <div>
+      <button type="button" class="go" hx-post="/admin/series/{{.Key}}/finish" hx-target="#detail-meta" hx-swap="outerHTML">Finish</button>
+      <button type="button" onclick="document.getElementById('confirm-finish').hidden = true">Cancel</button>
+    </div>
+  </div>
+</div>
+{{end}}
 {{end}}
 
 {{/* series-detail-meta is the meta line, and the answer a Check now or
@@ -54,6 +70,7 @@
   <span>{{.Readers}} readers</span>
   {{if .Corrected}}<span class="mark">{{.Corrected}}</span>{{end}}
   {{if .Pending}}<span class="mark">{{.Requested}}</span>{{end}}
+  {{if .FinishedSince}}<span class="mark">{{.FinishedSince}}</span>{{end}}
   {{if .Unpollable}}<span class="mark">unpollable</span>{{end}}
   {{if .NoCover}}<span class="mark">no cover</span>{{end}}
   {{if .Orphan}}<span class="mark">orphan</span>{{end}}

backend/internal/web/templates/series-list.html

@@ -47,7 +47,7 @@
   <span class="c-ch">{{.Ch}}</span>
   <span>{{.Age}}</span>
   <span class="c-rd">{{.Readers}}</span>
-  <span class="c-note">{{range .Notes}}<span class="mark">{{.}}</span>{{end}}{{if .More}}<span class="mark mark-faint">+{{.More}}</span>{{end}}</span>
+  <span class="c-note">{{range .Notes}}<span class="mark">{{.}}</span>{{end}}{{if .More}}<span class="mark mark-faint">+{{.More}}</span>{{end}}{{if .Finished}}<span class="mark mark-faint">finished</span>{{end}}</span>
   <span class="c-act">{{if .CanPoll}}<a class="ghost act" hx-post="/admin/series/{{.Key}}/poll" hx-target="closest .trow" hx-swap="outerHTML" hx-vals='{"band":{{if .Band}}1{{else}}0{{end}}}' href="#">Check now</a>{{end}}{{if .CanRemove}}<button class="ghost danger" hx-post="/admin/series/{{.Key}}/remove" hx-target="closest .trow" hx-swap="outerHTML" hx-include="#filterbar" hx-vals='{"band":{{if .Band}}1{{else}}0{{end}}}' hx-confirm="Removes this series and its stored cover. No Reader has it bookmarked; one re-bookmarking it recreates the row.">Remove</button>{{end}}</span>
   {{if .RemovalRefused}}<span class="row-msg">a Reader has bookmarked this Series again</span>{{end}}
 </div>

backend/internal/web/web.go

@@ -293,10 +293,11 @@ func libOf(q string) string {
 // buildListView loads one reader's list once and derives both the tab-filtered
 // items and the recent strip from it.
 //
-// Archived and finished series appear in their own tab and nowhere else — not
-// in All, not in Updated, not in Favourites, and not in the recent strip. An
-// archived favourite therefore shows only under Archived: Favourites means
-// "favourites I am currently reading".
+// Archived series appear in their own tab and nowhere else — not in All, not
+// in Updated, not in Favourites, and not in the recent strip. An archived
+// favourite therefore shows only under Archived: Favourites means "favourites
+// I am currently reading". There is no Finished tab: finished is a fact about
+// the Series, not a bookmark bucket (issue #157).
 func (h *Handler) buildListView(readerID int64, lib, tab string) (listView, error) {
 	all, err := h.store.List(readerID) // already ordered updated_at DESC
 	if err != nil {
@@ -327,8 +328,6 @@ func (h *Handler) buildListView(readerID int64, lib, tab string) (listView, erro
 		items = withNew
 	case "archived":
 		items = filterBookmarks(all, func(b store.Bookmark) bool { return b.Status == store.StatusArchived })
-	case "finished":
-		items = filterBookmarks(all, func(b store.Bookmark) bool { return b.Status == store.StatusFinished })
 	default:
 		tab = "all"
 		items = reading
@@ -392,7 +391,7 @@ func currentLib(r *http.Request) string {
 // writeChromeOOB appends the regions that live outside #list — the recent
 // strip, the Updated badge and the action key — as out-of-band swaps, so a
 // mutation cannot leave them describing the library as it was before the tap.
-// The key is in here because it is tab-shaped too: archived and finished swap
+// The key is in here because it is tab-shaped too: the archived bucket swaps
 // Archive for Restore.
 func (h *Handler) writeChromeOOB(w http.ResponseWriter, view listView) {
 	view.OOB = true
@@ -492,9 +491,9 @@ func (h *Handler) uiFavorite(w http.ResponseWriter, r *http.Request) {
 	h.saveAndRenderCard(w, r, b)
 }
 
-// uiStatus moves a bookmark between lifecycle buckets. This is the only place
-// a series can be marked finished — the JSON API refuses that value, so the
-// userscript cannot set it even by accident.
+// uiStatus moves a bookmark between the two lifecycle buckets. Finished is not
+// one of them: it is a fact about the Series, decided from the admin surface,
+// so the web UI's per-bookmark control cannot set it (issue #157).
 //
 // last_chapter_num is untouched, so Upsert keeps the stored updated_at and the
 // list does not reorder.
@@ -508,7 +507,7 @@ func (h *Handler) uiStatus(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	switch s := r.PostFormValue("status"); s {
-	case store.StatusReading, store.StatusArchived, store.StatusFinished:
+	case store.StatusReading, store.StatusArchived:
 		b.Status = s
 	default:
 		http.Error(w, "invalid status", http.StatusBadRequest)