mangaBookmark/backend/cover_test.go

package main

import (
	"database/sql"
	"net/http"
	"net/http/httptest"
	"strings"
	"testing"

	"bookmarkmanager/backend/internal/store"
)

func getCover(t *testing.T, srv http.Handler, path string, cookie *http.Cookie) *httptest.ResponseRecorder {
	t.Helper()
	req := httptest.NewRequest(http.MethodGet, path, nil)
	if cookie != nil {
		req.AddCookie(cookie)
	}
	rr := httptest.NewRecorder()
	srv.ServeHTTP(rr, req)
	return rr
}

// The acquired Cover is served from this deployment's own origin, to any
// browser rendering a third-party page — no session, no credential (ADR-0007).
func TestPublicCoverServesStoredBytesUnauthenticated(t *testing.T) {
	const sourceURL = "https://cdn.asurascans.com/covers/solo.webp"
	srv, st := newWebTestServer(t, testConfig())
	if err := st.PutCover(sourceURL, []byte("\x00webp-bytes"), "image/webp"); err != nil {
		t.Fatalf("PutCover: %v", err)
	}

	// The wire URL is what a client actually requests, so the path under test
	// is taken from it rather than rebuilt by hand.
	wire := st.CoverWireURL(store.CoverAddress(sourceURL))
	path, ok := strings.CutPrefix(wire, testCoverBaseURL)
	if !ok {
		t.Fatalf("wire URL %q is not on the public origin %q", wire, testCoverBaseURL)
	}
	rr := getCover(t, srv, path, nil)
	if rr.Code != http.StatusOK {
		t.Fatalf("status = %d, want 200 without any credential", rr.Code)
	}
	if got := rr.Body.String(); got != "\x00webp-bytes" {
		t.Fatalf("body = %q, want the stored bytes", got)
	}
	if got := rr.Header().Get("Content-Type"); got != "image/webp" {
		t.Fatalf("Content-Type = %q, want the stored one", got)
	}
	// Content-addressed bytes never change, so a client that has them must
	// never need to ask again.
	if got := rr.Header().Get("Cache-Control"); !strings.Contains(got, "immutable") {
		t.Fatalf("Cache-Control = %q, want an immutable cache directive", got)
	}
}

func TestPublicCoverRejectsUnknownAddress(t *testing.T) {
	srv, _ := newWebTestServer(t, testConfig())
	cases := map[string]string{
		"unknown":   "/covers/" + store.CoverAddress("https://cdn.example/never-stored.jpg"),
		"malformed": "/covers/not-an-address",
		"traversal": "/covers/../../etc/passwd",
		"empty":     "/covers/",
	}
	for name, path := range cases {
		t.Run(name, func(t *testing.T) {
			if rr := getCover(t, srv, path, nil); rr.Code == http.StatusOK {
				t.Fatalf("%s: status = 200, want anything but a served body", path)
			}
		})
	}
}

// A content type outside the image set is never echoed back. The old kagane
// proxy could fetch text/html from a challenged fetch and had to refuse it;
// the general route's only input is the store, and the store refuses to
// record anything that is not an image — but the guarantee is pinned at the
// serving boundary, not the write gate, so a poisoned row (migrated data, a
// writer that skips the gate) is also never served.
func TestPublicCoverNeverEchoesNonImage(t *testing.T) {
	const sourceURL = "https://cdn.example/cover"
	st, dsn := newTestStoreURL(t)
	// The write gate refuses non-image content types outright.
	if err := st.PutCover(sourceURL, []byte("<script>"), "text/html"); err == nil {
		t.Fatal("PutCover accepted a non-image content type")
	}
	// A legitimate row, then the content type flipped behind the store's back:
	// the bytes exist at the address, so only the type is hostile.
	address := store.CoverAddress(sourceURL)
	if err := st.SetSeriesCover("asura", "solo", sourceURL, []byte("<script>"), "image/png"); err != nil {
		t.Fatalf("seed row: %v", err)
	}
	db, err := sql.Open("pgx", dsn)
	if err != nil {
		t.Fatalf("open %s: %v", dsn, err)
	}
	defer db.Close()
	if _, err := db.Exec(`UPDATE covers SET content_type = 'text/html' WHERE address = $1`, address); err != nil {
		t.Fatalf("poison row: %v", err)
	}
	rr := getCover(t, newRouter(st, testConfig(), nil), "/covers/"+address, nil)
	if rr.Code == http.StatusOK {
		t.Fatalf("status = 200, want a refusal for a non-image row (body %q)", rr.Body.String())
	}
}

// The whole point of acquiring bytes is that the UI shows them: the card's
// <img> must carry the public address, not a third-party URL and not a
// placeholder.
func TestListRendersAcquiredCover(t *testing.T) {
	const sourceURL = "https://static.comix.to/039d/i/1/34/6a6742bf15736@280.jpg"
	srv, st := newWebTestServer(t, testConfig())
	if _, err := st.Upsert(st.OwnerID(), store.Bookmark{
		Key: "comix:n8we", Site: "comix", SeriesID: "n8we", Title: "Dungeons and Crayons",
		SeriesURL: "https://comix.to/title/n8we", UpdatedAt: 1000,
	}); err != nil {
		t.Fatalf("seed: %v", err)
	}
	if err := st.SetSeriesCover("comix", "n8we", sourceURL, []byte("\xff\xd8jpeg"), "image/jpeg"); err != nil {
		t.Fatalf("SetSeriesCover: %v", err)
	}

	req := httptest.NewRequest(http.MethodGet, "/ui/list", nil)
	req.AddCookie(sessionCookie(t, st))
	rr := httptest.NewRecorder()
	srv.ServeHTTP(rr, req)
	if rr.Code != http.StatusOK {
		t.Fatalf("status = %d, want 200", rr.Code)
	}
	want := `src="` + testCoverBaseURL + "/covers/" + store.CoverAddress(sourceURL) + `"`
	if !strings.Contains(rr.Body.String(), want) {
		t.Fatalf("rendered list does not contain %s", want)
	}
}