sulthan
af07314bb6
Uncommitted work from three design runs on this branch, against one design system: docs/design-system.md is updated to match the CSS, not the reverse. Library (Reader-facing): - .chrome sticks at top: 0. Search and the tab row were unreachable three screens into a 300-item library, which is exactly where they earn their keep; everything above them still scrolls away on purpose. - One :focus-visible ring (2px --paper) on the nine controls that defined none and fell back to the UA blue. .searchbar keeps its border recolour as a resting cue but no longer stands in for a ring. - Mono labels lift 10px -> 11px everywhere. The brief names night reading and glare as the usage scene; 10px small-caps was where taste overrode it. - A card in flight past 2s says "Saving..." and carries aria-busy. htmx sets neither, so the wait up to its 15s timeout was silent in both channels. - Titles clamp at 3 lines; .is-new .title takes width: fit-content, or -webkit-box stretches the ember underline past the text it sizes to. /admin: - Overview routes into Lanes when a lane is unhealthy, prefixes each figure with its column word on the phone layout that drops the thead, labels state cells for a screen reader, and has an empty state where the sites table assumed rows. - The admin shell picks up the library's chrome: htmx 15s timeout, the shared #notice slot, #sr-announce, filter.js. admin.css follows the same pass. - admin_render_test.go and card_render_test.go render the templates directly, so markup regressions in either surface fail without a browser. Login: - DISCORD_GUILD_NAME (optional) names the community on the login screen and in the refusal message, so a stranger knows which Discord to ask for an invite. Unset degrades to a generic label; neither form names the guild id. Handlers: - maxChapterNum (9999) bounds both typed-chapter paths. uiChapter and adminSeriesCorrectLatest each parsed a float64 with no ceiling, so a hand-rolled POST stored 1e308 and every later reader of that row inherited it. Matches the max on the card's chapter input. go test ./... green.
60 lines
1.9 KiB
Go
60 lines
1.9 KiB
Go
package web
|
|
|
|
import (
|
|
"html/template"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// The three administrative tables are grids on a mouse and label-value pairs
|
|
// on a phone, where the media query drops the .thead and prints each cell's
|
|
// data-label as its prefix instead. Without the attribute the collapsed row
|
|
// renders as bare figures — "1200.25 3d 4", "12 40 6h" — which no reader can
|
|
// decode, and nothing in Go or in a desktop render says so. Every cell whose
|
|
// only column heading was the .thead is asserted here.
|
|
func TestAdminTablesLabelCollapsedCells(t *testing.T) {
|
|
tmpl, err := template.ParseFS(templateFS, "templates/*.html")
|
|
if err != nil {
|
|
t.Fatalf("ParseFS: %v", err)
|
|
}
|
|
cases := []struct {
|
|
name string
|
|
data any
|
|
want []string
|
|
}{
|
|
{
|
|
"series-row",
|
|
seriesRowView{Key: "asura:x", Title: "Chronicles", Site: "asura", Ch: "1200.25", Age: "3d", Readers: 4},
|
|
[]string{`data-label="ch"`, `data-label="checked"`, `data-label="readers"`},
|
|
},
|
|
{
|
|
"lanes",
|
|
lanesView{Rows: []laneRow{{Site: "asura", Due: 12, Checked: 40, Gap: "6h", Ran: "4m ago"}}},
|
|
[]string{`data-label="due"`, `data-label="checked"`, `data-label="gap"`},
|
|
},
|
|
{
|
|
// The Site table's figures are a range over one slice, so their
|
|
// labels are the ones overviewView puts on the figs.
|
|
"overview",
|
|
overviewView{Sites: []siteRow{{Site: "asura", Figs: []fig{
|
|
{Label: "series", Href: "/admin/series", Count: 143},
|
|
{Label: "stale", Count: 0},
|
|
}}}},
|
|
[]string{`data-label="series"`, `data-label="stale"`},
|
|
},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
var out strings.Builder
|
|
if err := tmpl.ExecuteTemplate(&out, tc.name, tc.data); err != nil {
|
|
t.Fatalf("ExecuteTemplate: %v", err)
|
|
}
|
|
for _, want := range tc.want {
|
|
if !strings.Contains(out.String(), want) {
|
|
t.Errorf("missing %s: the collapsed phone row renders this cell as a bare figure", want)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|