fix(backend): strip rotating Asura build hash from bookmark keys

2026-07-28 06:45:53 +07:00
parent 6dce9fc481
commit d602b67b84
2 changed files with 149 additions and 0 deletions
@@ -905,3 +905,81 @@ func TestDueForLatestCheckSkipsFinishedKeepsArchived(t *testing.T) {
 		t.Fatal("due included a finished series")
 	}
 }
+
+// Asura slugs used to include the site build hash; rows keyed with it must
+// be rewritten to the stable ID on open, merging hash-generations of the
+// same series into the newest row.
+func TestOpenStoreMigratesAsuraBuildHashKeys(t *testing.T) {
+	dbPath := filepath.Join(t.TempDir(), "hash.db")
+
+	store, err := OpenStore(dbPath)
+	if err != nil {
+		t.Fatalf("open: %v", err)
+	}
+	seed := []Bookmark{
+		{Key: "asura:swordmasters-youngest-son-f886a8af", Site: "asura",
+			SeriesID: "swordmasters-youngest-son-f886a8af", Title: "Old gen",
+			LastChapterNum: 50, UpdatedAt: 100},
+		{Key: "asura:swordmasters-youngest-son-059befe1", Site: "asura",
+			SeriesID: "swordmasters-youngest-son-059befe1", Title: "Re-bookmarked",
+			LastChapterNum: 60, UpdatedAt: 200},
+		{Key: "asura:overgeared-059befe1", Site: "asura",
+			SeriesID: "overgeared-059befe1", Title: "Single gen", UpdatedAt: 150},
+		// Hash-like suffix on another site must be left alone.
+		{Key: "demonic:x-deadbeef", Site: "demonic",
+			SeriesID: "x-deadbeef", Title: "Not asura", UpdatedAt: 300},
+	}
+	for _, b := range seed {
+		if _, err := store.Upsert(b); err != nil {
+			t.Fatalf("seed %s: %v", b.Key, err)
+		}
+	}
+	if err := store.Close(); err != nil {
+		t.Fatalf("close: %v", err)
+	}
+
+	reopened, err := OpenStore(dbPath)
+	if err != nil {
+		t.Fatalf("reopen: %v", err)
+	}
+	t.Cleanup(func() { reopened.Close() })
+
+	list, err := reopened.List()
+	if err != nil {
+		t.Fatalf("List: %v", err)
+	}
+	byKey := map[string]Bookmark{}
+	for _, b := range list {
+		byKey[b.Key] = b
+	}
+	if len(list) != 3 {
+		t.Fatalf("want 3 rows after merge, got %d: %+v", len(list), list)
+	}
+	merged, ok := byKey["asura:swordmasters-youngest-son"]
+	if !ok {
+		t.Fatalf("merged key missing: %+v", byKey)
+	}
+	// Newest row wins the merge.
+	if merged.Title != "Re-bookmarked" || merged.LastChapterNum != 60 || merged.UpdatedAt != 200 {
+		t.Fatalf("merge kept wrong row: %+v", merged)
+	}
+	if merged.SeriesID != "swordmasters-youngest-son" {
+		t.Fatalf("series_id not stripped: %q", merged.SeriesID)
+	}
+	if _, ok := byKey["asura:overgeared-059befe1"]; ok {
+		t.Fatal("single-generation hashed key not rewritten")
+	}
+	if _, ok := byKey["asura:overgeared"]; !ok {
+		t.Fatal("single-generation row missing under stripped key")
+	}
+	if _, ok := byKey["demonic:x-deadbeef"]; !ok {
+		t.Fatal("non-asura row touched")
+	}
+
+	// Idempotent: a third open changes nothing.
+	third, err := OpenStore(dbPath)
+	if err != nil {
+		t.Fatalf("third open: %v", err)
+	}
+	third.Close()
+}