feat(web): split the UI into manga and novel libraries

backend/web_test.go

@@ -840,3 +840,127 @@ func TestMutationRefreshesChromeOutOfBand(t *testing.T) {
 		t.Fatalf("archiving did not clear the Updated badge out of band: %q", body)
 	}
 }
+
+// seedLibraries puts one manga and one novel row in the store.
+func seedLibraries(t *testing.T, st *store.Store) {
+	t.Helper()
+	seed(t, st, store.Bookmark{
+		Key: "asura:solo", Site: "asura", SeriesID: "solo",
+		Title: "Solo Leveling", Kind: store.KindManga, UpdatedAt: 2_000_000,
+	})
+	seed(t, st, store.Bookmark{
+		Key: "lightnovelworld:a-will-eternal", Site: "lightnovelworld",
+		SeriesID: "a-will-eternal", Title: "A Will Eternal",
+		Kind: store.KindNovel, UpdatedAt: 1_000_000,
+	})
+}
+
+func TestLibrariesAreDisjoint(t *testing.T) {
+	cfg := webConfig()
+	srv, st := newWebTestServer(t, cfg)
+	seedLibraries(t, st)
+
+	cases := []struct {
+		name, path, want, absent string
+	}{
+		{"manga is the default", "/ui/list?tab=all", "Solo Leveling", "A Will Eternal"},
+		{"novel is opt-in", "/ui/list?lib=novel&tab=all", "A Will Eternal", "Solo Leveling"},
+		{"unknown lib falls back to manga", "/ui/list?lib=comics&tab=all", "Solo Leveling", "A Will Eternal"},
+	}
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			rr := httptest.NewRecorder()
+			srv.ServeHTTP(rr, uiRequest(t, cfg, http.MethodGet, tc.path, nil))
+			if rr.Code != http.StatusOK {
+				t.Fatalf("status = %d, want 200", rr.Code)
+			}
+			body := rr.Body.String()
+			if !strings.Contains(body, tc.want) {
+				t.Fatalf("%s missing from %s", tc.want, tc.path)
+			}
+			if strings.Contains(body, tc.absent) {
+				t.Fatalf("%s leaked into %s", tc.absent, tc.path)
+			}
+		})
+	}
+}
+
+// A row written before the kind column existed has none. It is manga.
+func TestKindlessRowShowsInMangaLibrary(t *testing.T) {
+	cfg := webConfig()
+	srv, st := newWebTestServer(t, cfg)
+	seed(t, st, store.Bookmark{
+		Key: "asura:legacy", Site: "asura", SeriesID: "legacy",
+		Title: "Legacy Series", UpdatedAt: 1_000_000,
+	})
+
+	rr := httptest.NewRecorder()
+	srv.ServeHTTP(rr, uiRequest(t, cfg, http.MethodGet, "/ui/list?tab=all", nil))
+	if !strings.Contains(rr.Body.String(), "Legacy Series") {
+		t.Fatal("a row with no kind must appear in the manga library")
+	}
+}
+
+func TestNovelPageOmitsUpdatedTab(t *testing.T) {
+	cfg := webConfig()
+	srv, st := newWebTestServer(t, cfg)
+	seedLibraries(t, st)
+
+	rr := httptest.NewRecorder()
+	srv.ServeHTTP(rr, uiRequest(t, cfg, http.MethodGet, "/?lib=novel&tab=all", nil))
+	if rr.Code != http.StatusOK {
+		t.Fatalf("status = %d, want 200", rr.Code)
+	}
+	body := rr.Body.String()
+	if strings.Contains(body, "tab=new") {
+		t.Fatal("novel page must not offer the Updated tab")
+	}
+	// html/template escapes & to & inside an attribute value, so that — not
+	// the raw URL — is what lands in the body. htmx and the browser both decode
+	// it on read, so only the assertion has to know.
+	for _, want := range []string{
+		"/?lib=novel&tab=fav",
+		"/?lib=novel&tab=archived",
+		"/?lib=novel&tab=finished",
+	} {
+		if !strings.Contains(body, want) {
+			t.Fatalf("novel page missing tab link %s", want)
+		}
+	}
+	if !strings.Contains(body, `class="libswitch"`) {
+		t.Fatal("novel page missing the library switch")
+	}
+}
+
+func TestMangaPageKeepsUpdatedTab(t *testing.T) {
+	cfg := webConfig()
+	srv, st := newWebTestServer(t, cfg)
+	seedLibraries(t, st)
+
+	rr := httptest.NewRecorder()
+	srv.ServeHTTP(rr, uiRequest(t, cfg, http.MethodGet, "/?tab=all", nil))
+	body := rr.Body.String()
+	if !strings.Contains(body, "/?tab=new") {
+		t.Fatal("manga page must keep the Updated tab")
+	}
+	if strings.Contains(body, "lib=novel&tab=new") {
+		t.Fatal("the Updated tab must never be emitted for the novel library")
+	}
+}
+
+// tab=new is not offered for novels, so a hand-typed one must land on All
+// rather than an empty page.
+func TestNovelNewTabFallsBackToAll(t *testing.T) {
+	cfg := webConfig()
+	srv, st := newWebTestServer(t, cfg)
+	seedLibraries(t, st)
+
+	rr := httptest.NewRecorder()
+	srv.ServeHTTP(rr, uiRequest(t, cfg, http.MethodGet, "/ui/list?lib=novel&tab=new", nil))
+	if rr.Code != http.StatusOK {
+		t.Fatalf("status = %d, want 200", rr.Code)
+	}
+	if !strings.Contains(rr.Body.String(), "A Will Eternal") {
+		t.Fatal("novel tab=new should render the novel All list")
+	}
+}