Cinder pass across /admin, the login gate, and the library's a11y floor
Uncommitted work from three design runs on this branch, against one design system: docs/design-system.md is updated to match the CSS, not the reverse. Library (Reader-facing): - .chrome sticks at top: 0. Search and the tab row were unreachable three screens into a 300-item library, which is exactly where they earn their keep; everything above them still scrolls away on purpose. - One :focus-visible ring (2px --paper) on the nine controls that defined none and fell back to the UA blue. .searchbar keeps its border recolour as a resting cue but no longer stands in for a ring. - Mono labels lift 10px -> 11px everywhere. The brief names night reading and glare as the usage scene; 10px small-caps was where taste overrode it. - A card in flight past 2s says "Saving..." and carries aria-busy. htmx sets neither, so the wait up to its 15s timeout was silent in both channels. - Titles clamp at 3 lines; .is-new .title takes width: fit-content, or -webkit-box stretches the ember underline past the text it sizes to. /admin: - Overview routes into Lanes when a lane is unhealthy, prefixes each figure with its column word on the phone layout that drops the thead, labels state cells for a screen reader, and has an empty state where the sites table assumed rows. - The admin shell picks up the library's chrome: htmx 15s timeout, the shared #notice slot, #sr-announce, filter.js. admin.css follows the same pass. - admin_render_test.go and card_render_test.go render the templates directly, so markup regressions in either surface fail without a browser. Login: - DISCORD_GUILD_NAME (optional) names the community on the login screen and in the refusal message, so a stranger knows which Discord to ask for an invite. Unset degrades to a generic label; neither form names the guild id. Handlers: - maxChapterNum (9999) bounds both typed-chapter paths. uiChapter and adminSeriesCorrectLatest each parsed a float64 with no ceiling, so a hand-rolled POST stored 1e308 and every later reader of that row inherited it. Matches the max on the card's chapter input. go test ./... green.
This commit is contained in:
+21
-12
@@ -1200,7 +1200,9 @@ func TestLaneResumeRoundTrip(t *testing.T) {
|
||||
if !strings.Contains(body, `hx-post="/admin/lanes/asura/pause"`) || !strings.Contains(body, ">Pause</button>") {
|
||||
t.Errorf("resume response does not offer Pause again:\n%s", body)
|
||||
}
|
||||
if strings.Contains(body, "Resume") || strings.Contains(body, "paused") {
|
||||
// The page's own copy names pause as a healthy idle state, so the tell is
|
||||
// the row's phrase and the Resume control, not the bare word.
|
||||
if strings.Contains(body, ">Resume</button>") || strings.Contains(body, "resumes in") {
|
||||
t.Errorf("resume response still reads as paused:\n%s", body)
|
||||
}
|
||||
paused, _, err := st.LaneGates("asura")
|
||||
@@ -1252,7 +1254,7 @@ func TestPausedLaneRendersAsPausedNotStalled(t *testing.T) {
|
||||
}
|
||||
|
||||
body := lanesBody(t, router, st)
|
||||
if !strings.Contains(body, `class="ok">paused · resumes in 6h<`) {
|
||||
if !strings.Contains(body, `>paused · resumes in 6h<`) || !strings.Contains(body, `class="ok"`) {
|
||||
t.Errorf("a paused Lane does not render the patina phrase:\n%s", body)
|
||||
}
|
||||
if strings.Contains(body, `class="trow attention"`) {
|
||||
@@ -1652,7 +1654,9 @@ func TestChapterOverrideRejectsBadInput(t *testing.T) {
|
||||
Title: "Solo Leveling", LastChapterNum: 45, UpdatedAt: 1_000_000,
|
||||
})
|
||||
|
||||
for _, bad := range []string{"", "abc", "-3", "NaN", "Infinity", "-Inf"} {
|
||||
// 1e5 is past the ceiling but a perfectly good float64, so it only fails
|
||||
// if the handler bounds the value rather than just parsing it.
|
||||
for _, bad := range []string{"", "abc", "-3", "NaN", "Infinity", "-Inf", "10000", "1e5"} {
|
||||
t.Run("input "+bad, func(t *testing.T) {
|
||||
rr := httptest.NewRecorder()
|
||||
srv.ServeHTTP(rr, uiRequest(t, st, http.MethodPost,
|
||||
@@ -2678,11 +2682,14 @@ func TestSeriesListRowShape(t *testing.T) {
|
||||
if got := strings.Count(body, "Check now"); got != 2 {
|
||||
t.Errorf("Check now control count = %d, want 2 (only the two pollable rows):\n%s", got, body)
|
||||
}
|
||||
if got := strings.Count(body, ">Remove<"); got != 1 {
|
||||
t.Errorf("Remove control count = %d, want 1 (only the orphan):\n%s", got, body)
|
||||
if got := strings.Count(body, ">Remove<"); got != 2 {
|
||||
t.Errorf("Remove control count = %d, want 2 (opener + confirm for the orphan):\n%s", got, body)
|
||||
}
|
||||
if strings.Contains(body, "confirm-row") {
|
||||
t.Errorf("a confirm row renders in this batch:\n%s", body)
|
||||
if !strings.Contains(body, "confirm-row") {
|
||||
t.Errorf("expected hidden confirm-row for the orphan:\n%s", body)
|
||||
}
|
||||
if !strings.Contains(body, `hidden>`) {
|
||||
t.Errorf("confirm-row should be hidden initially:\n%s", body)
|
||||
}
|
||||
// No ember: the new-chapter signal stays off the admin surface. Scoped to
|
||||
// the page content — the shell's brand mark legitimately wears the ember
|
||||
@@ -3475,8 +3482,10 @@ func TestOverviewPerSiteTableLinksToNarrowedLists(t *testing.T) {
|
||||
srv := newRouter(st, testConfig())
|
||||
body := overviewBody(t, srv, st)
|
||||
|
||||
// The landed grid pins six columns; the header states them in order.
|
||||
if !strings.Contains(body, `<div class="thead"><span>Site</span><span>Series</span><span>No cover</span><span>Never chk</span><span>Stale</span><span>State</span></div>`) {
|
||||
// The landed grid pins six columns; the header states them in order. Cell
|
||||
// attributes (tooltips) are not part of the contract, the words are.
|
||||
thead := regexp.MustCompile(`<div class="thead"><span[^>]*>Site</span><span[^>]*>Series</span><span[^>]*>No cover</span><span[^>]*>Never checked</span><span[^>]*>Stale</span><span[^>]*>Status</span></div>`)
|
||||
if !thead.MatchString(body) {
|
||||
t.Errorf("per-Site table is not the six pinned columns:\n%s", body)
|
||||
}
|
||||
// The Site label is a door to the Site-narrowed list.
|
||||
@@ -4221,8 +4230,8 @@ func TestSeriesRemoveRendersOnlyOnOrphans(t *testing.T) {
|
||||
router := newRouter(st, testConfig())
|
||||
|
||||
body := adminSeriesPage(t, router, st, "")
|
||||
if got := strings.Count(body, ">Remove<"); got != 1 {
|
||||
t.Errorf("list offers Remove %d times, want 1 (only the orphan):\n%s", got, body)
|
||||
if got := strings.Count(body, ">Remove<"); got != 2 {
|
||||
t.Errorf("list offers Remove %d times, want 2 (opener + confirm for orphan):\n%s", got, body)
|
||||
}
|
||||
for _, tc := range []struct {
|
||||
key string
|
||||
@@ -4409,7 +4418,7 @@ func TestRemoveRacedBookmarkIsRefusedNotError(t *testing.T) {
|
||||
if !strings.Contains(body, "a Reader has bookmarked this Series again") {
|
||||
t.Errorf("refusal does not say what happened:\n%s", body)
|
||||
}
|
||||
if !strings.Contains(body, `class="c-rd">1</span>`) {
|
||||
if !strings.Contains(body, `data-label="readers">1</span>`) {
|
||||
t.Errorf("refusal does not render the fresh count:\n%s", body)
|
||||
}
|
||||
var one int
|
||||
|
||||
Reference in New Issue
Block a user