review: fix overviewView docstring to document fail-open fault reads

This commit is contained in:
2026-08-23 11:26:30 +07:00
parent 820f57a7fa
commit 8e6f4d2053
+5 -2
View File
@@ -64,8 +64,11 @@ type siteRow struct {
// overviewView assembles the landing page from the store's read model: one // overviewView assembles the landing page from the store's read model: one
// SeriesShapes pass per filter summed in Go (the shipped surface offers ten // SeriesShapes pass per filter summed in Go (the shipped surface offers ten
// grouped passes, not a stats query — #140), the pass log's latest pass per // grouped passes, not a stats query — #140), the pass log's latest pass per
// Site, and the roster. A failure in any read is a 500 with a logged reason, // Site, and the roster. A failure in the SeriesShapes, pass or roster reads
// never a page of silent zeroes. // is a 500 with a logged reason, never a page of silent zeroes. The three
// fault-input reads (RefusingSince, SidecarOK, NoChapterShare) fail open:
// a failing read logs and contributes no fault, so the landing page still
// renders — the same fail-open the poller uses for owner notices.
func (h *Handler) overviewView() (overviewView, error) { func (h *Handler) overviewView() (overviewView, error) {
now := time.Now() now := time.Now()
cutoff := now.Add(-ownerWindow).UnixMilli() cutoff := now.Add(-ownerWindow).UnixMilli()