fix: scope headless-shell to a dedicated network, off the Traefik proxy network

Prod override put headless-shell on the externally-managed `proxy`
network so manga-api (confined there for Traefik routing) could still
resolve it. That reopened CDP (port 9222, raw remote code execution)
to every other container on that shared network, not just manga-api.

Give both services a project-private `browser` network (defined in
the base compose file, not `internal: true` since headless Chrome
needs outbound access to kagane.to). manga-api joins both `proxy` and
`browser` in the prod override; headless-shell never touches `proxy`.
This commit is contained in:
2026-08-03 17:52:34 +07:00
parent 2c7b4952f3
commit 3adbfb7ad9
2 changed files with 19 additions and 6 deletions
+8 -5
View File
@@ -21,8 +21,12 @@ services:
BROWSER_WS_URL: ${BROWSER_WS_URL:-ws://headless-shell:9222} BROWSER_WS_URL: ${BROWSER_WS_URL:-ws://headless-shell:9222}
depends_on: depends_on:
- headless-shell - headless-shell
# `networks:` here replaces the base file's list entirely, so both must be
# named: `proxy` for Traefik routing, `browser` (defined in the base file)
# to keep reaching headless-shell without putting it on `proxy` too.
networks: networks:
- proxy - proxy
- browser
labels: labels:
- "traefik.enable=true" - "traefik.enable=true"
- "traefik.docker.network=${PROXY_NETWORK:-proxy}" - "traefik.docker.network=${PROXY_NETWORK:-proxy}"
@@ -40,11 +44,10 @@ services:
- "traefik.http.routers.mangaweb.tls.certresolver=${TRAEFIK_CERTRESOLVER:-le}" - "traefik.http.routers.mangaweb.tls.certresolver=${TRAEFIK_CERTRESOLVER:-le}"
- "traefik.http.routers.mangaweb.service=mangabm" - "traefik.http.routers.mangaweb.service=mangabm"
# manga-api only joins `proxy` in this override (see above), so headless-shell # headless-shell is untouched here: it keeps its `browser` network membership
# has to follow it there too or DNS resolution of headless-shell:9222 breaks. # from the base file and must never join `proxy` — that network is shared
headless-shell: # with whatever else sits behind Traefik on this host, and an exposed
networks: # CDP endpoint on it would be remote code execution for any of them.
- proxy
networks: networks:
proxy: proxy:
+11 -1
View File
@@ -45,6 +45,8 @@ services:
# the public internet does not. # the public internet does not.
ports: ports:
- "127.0.0.1:8080:8080" - "127.0.0.1:8080:8080"
networks:
- browser
headless-shell: headless-shell:
image: chromedp/headless-shell:stable image: chromedp/headless-shell:stable
@@ -55,12 +57,20 @@ services:
# container's lifetime. # container's lifetime.
init: true init: true
# Deliberately no `ports:` — an exposed CDP endpoint is remote code # Deliberately no `ports:` — an exposed CDP endpoint is remote code
# execution. Only the backend on the internal network may reach it. # execution. Only manga-api, via the `browser` network below, may reach it.
command: command:
- --remote-debugging-address=0.0.0.0 - --remote-debugging-address=0.0.0.0
- --remote-debugging-port=9222 - --remote-debugging-port=9222
- --disable-gpu - --disable-gpu
- --no-sandbox - --no-sandbox
networks:
- browser
volumes: volumes:
bookmarks-data: bookmarks-data:
networks:
# Not `internal: true`: headless Chrome still needs outbound access to reach
# kagane.to. Isolation here comes from membership (only manga-api and
# headless-shell join it), not from cutting egress.
browser: